Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

feat(extension): open typed sim/ links through the Sim link resolver - #9486

Merged
waleedlatif1 merged 2 commits into
stagingfrom
feat/extension-sim-links
Oct 30, 2026
Merged

feat(extension): open typed sim/ links through the Sim link resolver#9486
waleedlatif1 merged 2 commits into
stagingfrom
feat/extension-sim-links

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Typing sim/<name> in Chrome's address bar now opens the organization's Sim link: one static declarativeNetRequest rule rewrites top-level navigations to http(s)://sim/* to <Sim origin>/sim/*, keeping the path and query
  • The ruleset is generated at build time from SIM_EXTENSION_ORIGIN, like the rest of the origin-bound manifest
  • Adds declarativeNetRequestWithHostAccess (no install warning of its own) and http(s)://sim/* host access, used only by that rule; every navigation to sim is redirected before it loads and no other request is matched
  • README and DESIGN permission sections updated, including that an organization already serving an intranet host named sim would have those links redirected
  • Adding a required host permission makes Chrome ask existing installs to re-approve on update
  • Depends on feat(sim-links): organization Sim links (go links) with sim/<name> redirects #9484 (the /sim/<name> resolver); merge after it

Type of Change

  • New feature

Testing

  • Packaged-extension E2E in real Chromium (19/19): new check navigates to http://sim/handbook and http://sim/jira/123?view=board and lands on the configured origin's resolver; with the ruleset disabled it fails with ERR_NAME_NOT_RESOLVED
  • bun run --cwd apps/extension type-check, biome, check:source-text, check:comment-hygiene, check:guidance-refs

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 30, 2026 11:33pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge after its declared resolver dependency, #9484.

Summary

Adds a build-generated Chrome redirect rule that sends http(s)://sim/<path> to the configured Sim origin’s /sim/<path>.

  • Typed sim/<name> links open the Sim link resolver.

waleedlatif1 explicitly requires #9484 to merge first because it supplies the resolver. This assessment respects that dependency; this PR does not contain the resolver.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["Top-level navigation to http(s)://sim/path?query"] --> B["Chrome static redirect rule"]
  B --> C["Configured Sim origin /sim/path?query"]
  C --> D["Resolver supplied by #9484"]
Loading

Reviews (1) · Last reviewed commit: "feat(extension): open typed sim/ links t..." · Reviewed by Greptile

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 30, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 91479e6 into staging Oct 30, 2026
68 of 69 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/extension-sim-links branch October 31, 2026 00:05

This branch was previously deployed

1 inactive deployment
Preview — 4c04eb71 Deployed Oct 30, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1