Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

feat(sim-links): organization Sim links (go links) with sim/<name> redirects - #9484

Merged
waleedlatif1 merged 14 commits into
stagingfrom
feat/sim-links
Oct 30, 2026
Merged

waleedlatif1 merged 14 commits into
stagingfrom
feat/sim-links

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Sim links (go links): short sim/<name> links that take everyone in an organization to a destination. New Sim Links page in the org sidebar, available to Search and regular seats alike
  • sim.ai/sim/<name>[/values] resolves the viewer's organization link and redirects; signed-out visitors sign in and continue, and an unknown name offers to create it
  • Names match case- and punctuation-insensitively (sim/Q4-goals = sim/q4goals); plain links append extra path segments, {*} variable links fill values in order with an optional default destination
  • Destinations must be http(s), and {*} can never change the origin, so a value can't redirect off-site
  • Unlist hides a link from browsing (it still resolves); Restrict editing limits edit/delete to the creator and org admins; only they can change either setting
  • New sim_link table (additive migration), org operations through defineAuthorizedOrganizationUseCase, sim_link.created/updated/deleted audit entries
  • Gated by the org-scoped sim-links feature flag (SIM_LINKS fallback off AppConfig); routes 403 and the page/resolver 404 while off
  • The list shows each link's description and destination, creator, opens, and last change, with Unlisted/Restricted tags; A–Z and Most used views (redirects are counted; a link opened without its values is not)
  • The resolver decodes typed paths, so a Chrome site-search shortcut (sim jira/123, pushable to managed browsers via SiteSearchSettings) works today
  • Moves the "Load more" control to a shared SettingsListPagination reused by Search sources and Sim Links
  • Docs: search/sim-links (including the address-bar shortcut), audit-log action table
  • Follow-up: the browser extension rewrites http://sim/* to <origin>/sim/* so typing sim/handbook in the address bar works

Type of Change

  • New feature

Testing

  • lib/sim-links/destination.test.ts: origin escape via {*}, value encoding, missing values, default destination, http-only; each guard reverted to confirm its cases go red
  • scripts/test-sim-links-e2e.ts (12/12 against a local app + disposable DB, wired into the SCIM HTTP E2E group): sign-in redirect, case/punctuation resolution, appending, variable fill with hostile values, validation, conflict, unlisted visibility, restricted edits, access-setting changes by non-owners, cross-org isolation, visit counting and most-used order, encoded and spaced values, delete, audit entries
  • Headless browser QA of the page, editor, validation, conflict, search, and the not-found → create flow
  • check:migrations, drizzle-kit generate (no drift), api-validation:strict, boundaries, permission-group-enforcement, principal-kind-parity, application-graph, react-query, client-boundary, file-names, source-conventions, comment-hygiene, utils, test-patterns, script-tests, biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 30, 2026 21:30
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 30, 2026 11:40pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 42 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/scripts/test-sim-links-e2e.ts Resolved
Comment thread apps/sim/lib/sim-links/validation.ts Resolved
@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain from this review.

Summary

Adds organization-wide Sim Links with editable destinations, variable values, access settings, visit counts, audit entries, and an organization feature flag.

  • Organization members can open a short Sim link to reach its saved destination.
  • Organizations can create and manage their own Sim Links.
  • Search source lists and Sim Links share one load-more control.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A["Open /sim/name/values"] --> B{"Signed in?"}
  B -->|No| C["Sign in and return"]
  B -->|Yes| D["Find the member's organization"]
  D --> E{"Sim Links enabled?"}
  E -->|No| F["Show 404"]
  E -->|Yes| G["Look up the organization's link"]
  G --> H{"Destination resolved?"}
  H -->|Yes| I["Count visit and redirect"]
  H -->|No| J["Explain missing link or invalid values"]
Loading

Reviews (8) · Last reviewed commit: "improvement(sim-links): hold the leading..." · Reviewed by Greptile

Comment thread apps/sim/lib/sim-links/validation.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 42 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/app/sim/[[...path]]/page.tsx Resolved
Comment thread apps/sim/lib/sim-links/repository.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 42 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/scripts/test-sim-links-e2e.ts Resolved
Comment thread apps/sim/app/sim/[[...path]]/page.tsx Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 44 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 49 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 49 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 00e25a4 into staging Oct 30, 2026
71 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/sim-links branch October 31, 2026 00:05

This branch was previously deployed

1 inactive deployment
Preview — d427eb32 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant