Repository navigation
Skip disk syncs for the throwaway test database - #312
Draft
schlessera wants to merge 1 commit into
Draft
schlessera wants to merge 1 commit into
schlessera wants to merge 1 commit into
Conversation
The test database only lives as long as the runner, so it does not need to survive a crash. Let MySQL and MariaDB write without waiting for each commit to reach the disk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses wp-cli/wp-cli-tests#387.
The functional tests run against a database that is thrown away with the runner, yet MySQL and MariaDB wait for every commit, table creation and import to reach the disk. Restoring the cached WordPress installation, which most scenarios do, took 299 ms with full durability and 79 ms without in local measurements.
This relaxes the durability settings of the test database server. No test relies on the database surviving a crash, so the results should not change. Measurements are recorded on wp-cli/wp-cli-tests#387.