Repository navigation
Add scroll triggered animations feature - #4163
Merged
Merged
Conversation
captainbrosset
commented
Jul 8, 2026
bramus
suggested changes
Aug 13, 2026
Contributor
Author
|
Sorry about the copilot review comments, I clicked the button by accident. |
Contributor
Author
|
Thank you @bramus for the review! |
ddbeck
requested changes
Sep 23, 2026
ddbeck
left a comment
Collaborator
There was a problem hiding this comment.
Marking this as changes requested, since there seems to be some more work to do here.
@captainbrosset do you intend to return to this? Or would you like some help picking this up?
…croll-triggered-animations
…-dx/web-features into scroll-triggered-animations
Contributor
Author
I just pushed a commit which should address the comments. |
bramus
reviewed
Sep 24, 2026
bramus
left a comment
Contributor
There was a problem hiding this comment.
Not sure about the current wording either. Here’s my attempt.
I’ll leave it up to you to determine if this is better or not.
Co-authored-by: Bramus <bramus@bram.us>
ddbeck
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4128
@bramus please take a first look at this and let me know if you like the description.