Repository navigation
fix(changeprovider): reject null Phabricator diffs - #992
Open
Tmwakalasya wants to merge 1 commit into
Open
Tmwakalasya wants to merge 1 commit into
Tmwakalasya wants to merge 1 commit into
Conversation
Tmwakalasya
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 29, 2026 20:44
behinddwalls
approved these changes
Oct 30, 2026
behinddwalls
enabled auto-merge
October 30, 2026 14:56
Contributor
Author
|
@behinddwalls Just investigated the CI failure , the React 18 runtime test hit its 5-second timeout. The Phabricator provider tests, build, and integration checks all passed, so this looks unrelated to my change. Could you please rerun the failed Unit Test job when you have a chance and thank you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
A Conduit response containing a requested diff as JSON
nullpasses the map-key check but leaves a nil*diffResult. The provider's publicGetmethod then panics when converting that diff to change information. This was reproduced with a local HTTP fixture containing one valid diff and one null diff.What?
Treat a null requested diff like a missing diff at the response parser boundary. Return the existing missing-diff error before conversion, so a partially valid response does not panic or return partial change information.
Test Plan
convertToChangeInfo../tool/bazel test //submitqueue/extension/changeprovider/phabricator:go_default_test --test_output=errorspassed, including the existing valid-response controls.make fmt,make lint,make check-tidy, andmake check-gazellepassed.This is defensive handling of a constructed response, not a reported production incident. The full integration/e2e suites were not run.
Issue
No linked issue.