Repository navigation
feat(postgres): include column comments in schema context - #193
Open
gezerui888 wants to merge 2 commits into
Open
gezerui888 wants to merge 2 commits into
gezerui888 wants to merge 2 commits into
Conversation
Author
|
I pinned CI to pnpm 10.34.8 after the unpinned version failed during dependency installation. Frozen-lockfile installation, lint, the PostgreSQL 16 integration test, and the production build pass with this version. |
Author
|
Hi @tianzhou, could you review my PostgreSQL column comments change when you have time? Thanks for your help. |
Author
|
Hi @tianzhou, I would appreciate a review when you have time. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL schema context omitted column comments. I now include them as
COMMENT ON COLUMNstatements, with identifiers and comment text escaped by PostgreSQL. Comments stay with the correct schema and column, including after a column is dropped.I added a PostgreSQL integration test and connected it to PR CI. This covers the PostgreSQL part of #155.
Tests: PostgreSQL 16 integration test (fails on the original connector, passes with the change),
npm run lint, andnpm run build.