Repository navigation
Ignore data generated under tests/samples by recipe tests - #3110
Open
quetion667 wants to merge 1 commit into
Open
quetion667 wants to merge 1 commit into
quetion667 wants to merge 1 commit into
Conversation
Recipe tests point --data_folder at tests/samples/<dir>, and several recipes derive write locations from it: data_folder_noise/data_folder_rir (<data_folder>/noise, <data_folder>/rir) where the noise and RIR archives are downloaded and unpacked, and the ESC50 manifests (<data_folder>/manifest). These showed up as untracked files after running the recipe tests. Fixes speechbrain#2608 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recipe tests run recipes with
--data_folder tests/samples/<dir>, and several recipes derive write locations fromdata_folder:data_folder_noise: !ref <data_folder>/noiseanddata_folder_rir: !ref <data_folder>/rir, whereprepare_dataset_from_URLdownloads and unpacks the noise/RIR archives;train/valid/test_annotation: !ref <data_folder>/manifest/*.json, written byesc50_prepare.py.None of these are ignored, so running the recipe tests leaves untracked directories in the repo. I cross-checked every row of
tests/recipes/*.csv(data folder override + hparams + whethertrain.pyrunsprepare_noise_data/prepare_rir_data). On currentdevelopthe generated directories are the ones listed in the issue plus three more:tests/samples/ASR/noise/,ASR/rir/tests/samples/ESC50/manifest/tests/samples/VAD/noise/tests/samples/lang/noise/,lang/rir/tests/samples/separation/noise/tests/samples/single-mic/noise/,single-mic/rir/This PR adds three patterns next to the existing
tests/tmp//tests/download/entries:*matches a single level, so the trackedtests/samples/noise/andtests/samples/RIRs/are not affected;git ls-files -ci --exclude-standardis empty.Side note: on case-insensitive setups (e.g. Windows) the existing PyInstaller
MANIFESTrule already hidesESC50/manifest/by accident, which is why it only shows up on Linux/macOS.Fixes #2608
Testing:
prepare_esc50with the same argumentstrain.pyuses for the recipe test: before,git -c core.ignorecase=false statusliststests/samples/ESC50/manifest/*.json; after, nothing.data.zip+ unpacked files) in all eight directories instead of downloading the ~570 MB archive: all listed as untracked before, none after.git check-ignoreon tracked sample files: not ignored.pre-commit run --files .gitignore: passed..gitignore.No breaking changes.
This change was prepared with Claude Code and reviewed by the author.
Before submitting
🤖 Generated with Claude Code