Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

a8n: add branch flag for creating campaigns - #96

Merged
mrnugget merged 3 commits into
masterfrom
kz/a8n-campaign-branch
Feb 13, 2020
Merged

mrnugget merged 3 commits into
masterfrom
kz/a8n-campaign-branch

Conversation

@kzh

@kzh kzh commented Jan 29, 2020

Copy link
Copy Markdown
Contributor

This PR adds a flag to specify a branch name when creating campaigns.

@kzh
kzh requested a review from mrnugget January 29, 2020 14:47
@mrnugget

Copy link
Copy Markdown
Contributor

Idea as suggested by @sqs in https://github.com/sourcegraph/sourcegraph/issues/7850#issuecomment-577674931:

It would be cool if the branch name could also be specified in the Markdown file by using a comment, such as:

Title of the campaign

Description

// branch = my-branch-name

There's precedent here: sometimes blog engines or static site generators allow you to add "front matter" to a page, in the form of YAML/TOML/JSON (see Hugo's explanation of it here: https://gohugo.io/content-management/front-matter/)

I don't think we need to fully support that, but some way to declare a line as "meta" would be great.

@mrnugget

mrnugget commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Update on my previous comment here: it's more important to get this merged with the basic functionality (-branch flag!) than the additonal functionality of specifying the branch name in the markdown file.

@kzh
kzh marked this pull request as ready for review February 5, 2020 09:33
@kzh
kzh force-pushed the kz/a8n-campaign-branch branch from 19ba1bc to 7acad7a Compare February 5, 2020 09:37
@mrnugget

Copy link
Copy Markdown
Contributor

Merging this now since https://github.com/sourcegraph/sourcegraph/pull/8111 has been merged.

I also added a commit that documents this new flag and prints it in the friendly output message.

@mrnugget
mrnugget merged commit 52c5f0e into master Feb 13, 2020
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* a8n: add branch flag for creating campaigns

* Add condition for manual campaigns

* Document branch option in help output and friendly format message

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
@keegancsmith
keegancsmith deleted the kz/a8n-campaign-branch branch November 11, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants