Repository navigation
improvement(sim-links): use the shared resource table layout - #9491
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge, with no new actionable issues found. SummarySim Links now uses the shared
Reviews (7) · Last reviewed commit: "improvement(sim-links): context-menu anc..." · Reviewed by Greptile |
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Turn on auto-fix | Re-trigger cubic
… shared no-results, menu order, columns)
… resource props, docs match the UI
68003a4 to
f713c73
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 16 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Resourcelayout like Tables, Files, and Tests: header with a primary New link, the search + sort toolbar, and a full-width tablesim/name), Destination (widest), Description, Created by, Access (Unlisted / Restricted), Updated. Open counts drive Sort → Opens rather than a column, so Destination gets the widthdir, paging by name both ways and returning opens as a single pageResourceChromeFallbackchrome (columns, New link, search, sort) until the first page arrives;ResourceNoResultsgains an optionalsearchScope, and shared Resource props accept readonly arrays;OrganizationPageTabis no longer exported now that nothing imports itType of Change
Testing
scripts/test-sim-links-e2e.ts(12/12 against a local app + disposable DB), now asserting name Z–A and least-opened-first orderinglib/sim-links/destination.test.ts, biome,check:react-query,check:client-boundary,check:api-validation:strict,check:boundaries,check:application-graph,check:file-names,check:source-conventions,check:comment-hygiene,check:utils,check:test-patterns,check:source-textChecklist
test-auditauthoring gate)