Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

fix(search): accept Fireflies data-array responses - #9490

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/fireflies-list-envelope
Oct 31, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/fireflies-list-envelope

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Accept Fireflies transcript lists returned as { data: [...] }, which previously marked the provider unavailable after a successful MCP call.
  • Use the existing document validation, pagination and partial-coverage handling. Preserve supported envelopes and rejection of malformed canonical fields.

Type of Change

  • Bug fix

Testing

  • Wrote the regression cases first. Pre-fix CI failed exactly the three new data-array cases: populated pagination, an empty page, and a page containing an invalid row. The other 25 meeting-provider cases passed; that app shard had 19,434 passing tests and 7 skipped.
  • Local lint, all 62 audits, all 29 workspace type checks, required generators and the block-registry check passed. Independent test-audit and correctness reviews found no issues.
  • Candidate CI passed all 39 jobs, including unit/type, lint, builds, integration, desktop, mobile and browser-extension checks. All 28 meeting-provider cases passed; the app shard passed 19,437 tests with 7 skipped. No local tests were run.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 12:58am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Accepts Fireflies transcript lists returned as { data: [...] } without changing how documents or page offsets are checked.

  • Fireflies search accepts transcript lists inside data.

Reviews (1) · Last reviewed commit: "fix(search): accept Fireflies data-array..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 3a39177 into staging Oct 31, 2026
69 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fireflies-list-envelope branch October 31, 2026 01:14

This branch was previously deployed

1 inactive deployment
Preview — 31cf28ee Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant