Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

chore(trigger): run tasks on the bun-1.4 runtime - #9481

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/trigger-bun-1-4
Oct 30, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/trigger-bun-1-4

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Run Trigger.dev tasks on runtime: 'bun-1.4' (Bun 1.4.4), matching the app, realtime, and db images, which already run on Bun 1.4.4
  • Bump @trigger.dev/sdk, core, build and the CI trigger.dev CLI from 4.7.6 to 4.8.2, the first release with bun-1.4
  • Add a nodeBinary() build extension: the bun-1.4 image ships no node, but the isolated-vm sandbox and the Oracle worker run as node child processes. It copies Node 24.22.1 from a digest-pinned node:24.22.1-bookworm-slim, the same version as docker/app.Dockerfile. Because the layer adds image instructions, Trigger.dev builds the install stage from this base too, so isolated-vm's install script runs against that Node. Deploy only; trigger dev uses the local node
  • distrustCompromisedRoots() stays in init. Under Bun 1.4.4 the roots are already absent, so it does nothing; docs updated

Hold the merge until 2026-11-05 ~13:36 UTC. @trigger.dev/*@4.8.2 was published 2026-10-29, and bunfig.toml's 7-day minimumReleaseAge cool-down has not elapsed. CI still installs because the frozen-lockfile install does not re-check release age, so the hold is policy, not a CI failure. The gate is left as is.

Type of Change

  • Chore

Testing

  • Rendered the Containerfile with the pinned trigger.dev@4.8.2 generateContainerfile (bun-1.4 + this layer): base COPYs Node and checks its version; the install stage builds FROM base
  • Built that same stage layout locally for linux/amd64 from triggerdotdev/bun:1.4-bookworm (the CLI's pinned digest), using bun install with the real externals (isolated-vm 6.2.0, sharp, @napi-rs/canvas, pdfjs-dist):
    • Bun 1.4.4 → spawn('node', ['--no-node-snapshot', …]) → Node v24.22.1, and isolated-vm evaluates 1+1 = 2
    • sharp renders a PNG, and @napi-rs/canvas and pdfjs-dist load under Bun
    • With the Node layer removed, the spawn fails, so the layer is required
  • biome check on changed files; type-check, audits, and tests run in CI
  • Post-merge: watch the first staging deploy and a function-block run on Trigger.dev staging

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 30, 2026 8:57pm UTC

Request Review

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 30, 2026 20:50
@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] No additional changes are required by this review; keep the author's stated merge delay.

Summary

Moves Trigger.dev tasks to bun-1.4 while keeping Node for the sandbox and Oracle workers.

  • Deployed Trigger.dev tasks run on Bun while Node handles child workers.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["Trigger.dev task: Bun"] --> B["Sandbox worker: Node 24.22.1"]
  A --> C["Oracle worker: Node 24.22.1"]
  D["nodeBinary() image layer"] --> B
  D --> C
Loading

Reviews (1) · Last reviewed commit: "chore(trigger): run tasks on the bun-1.4..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/trigger.config.ts Resolved
@waleedlatif1
waleedlatif1 merged commit 397ea37 into staging Oct 30, 2026
137 of 139 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/trigger-bun-1-4 branch October 30, 2026 21:12

This branch was successfully deployed

1 active deployment
Preview — 8ef877db Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant