Repository navigation
Default missing layer offset axes independently - #90
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layers with only
offsetxcurrently raiseKeyError: offsety; layers with onlyoffsetysilently lose their vertical offset. Both axes default independently to zero in the Tiled formats.Read each optional axis separately in the shared JSON and TMX layer parsers. This covers tile, object, image and group layers, including nested groups.
References: TMX layer offsets, JSON layer offsets.
Validation: 24 regression cases fail on development (32 controls pass); all 182 tests pass with the fix, with 96% coverage. Mypy passes. The new test file passes Black, isort, Ruff and flake8. Whole-package checks still report existing failures: Ruff findings, Black file list and isort file list match the base; flake8 adds no findings and removes one existing overlong line.
AI-assisted by Codex; the assistant prepared and tested this change.