Repository navigation
Reject deep-linking payloads with a trailing newline - #5387
Open
xubenqiang wants to merge 1 commit into
Open
xubenqiang wants to merge 1 commit into
xubenqiang wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5386
create_deep_linked_urlvalidated the payload withre.match(r"^[A-Za-z0-9_-]+$", payload). In Python,$also matches just before a trailing newline, so"valid\n"passed and the returned URL contained a literal newline, even though the documented payload character set isA-Z,a-z,0-9,_and-.Change
src/telegram/helpers.py: usere.fullmatch(r"[A-Za-z0-9_-]+", payload), so the whole string must match the documented set.group=Truegoes through the same check.Tests
tests/test_helpers.py::TestHelpers::test_create_deep_linked_urlnow also asserts that"hello\n","hello\r"and"hello\nworld"raiseValueErrorfor bothgroup=Falseandgroup=True.Verified locally:
pytest tests/test_helpers.py -q-> 183 passed; with onlyhelpers.pyreverted, the new assertions fail withDID NOT RAISE ValueErrorfor"hello\n".ruff checkandruff format --checkare clean on both files.Check-list for PRs
AUTHORS.rst(optional) - not done, can add if you prefer__all__s - not applicable