Repository navigation
Conversation
Fixes python-quantities#108. Normalize dimensionless numeric bounds before rescaling, preserving dimensional-bound validation and output behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clipping a dimensionless Quantity with numeric limits currently raises
AttributeError:This should return
[0., 0.5, 1.] dimensionless. Convert the bounds to quantities before rescaling them, after the existing check that requires quantity-valued bounds for dimensional inputs.Fixes #108. The regression covers scalar, array and one-sided bounds,
np.clip, output buffers and incompatible units. Both the full suite and README doctests pass on Python 3.10/NumPy 1.24 and Python 3.12/NumPy 2.4 and 2.5. Mypy passes on NumPy 1.24 and 2.4; NumPy 2.5 has the samequantity.pyierror on unchanged master, already addressed by #277. The advisory lint results are unchanged.I also checked clipping normalized channels from PhysioNet's S001R01 EEG recording against NumPy magnitude calculations: all 24 previously failing configurations now complete, and the eight configurations with explicit Quantity bounds retain identical results.