Repository navigation
Fix pond force unit definition - #275
Merged
Merged
Conversation
loaff123
marked this pull request as ready for review
October 2, 2026 09:03
Contributor
|
Thanks for this. Do you think it makes sense to add kilopond? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44.
The pond definition uses
g_0 * kg, so one pond converts to 9.80665 N. A pond is one gram-force, or 0.00980665 N. Change the mass factor togramwhile preserving its name,psymbol, andpondsalias.Add a changelog entry and coverage for SI conversion, arrays, names, force dimensionality, and unchanged gram-force/kilogram-force conversions. This deliberately corrects existing pond conversions by a factor of 1,000.
Validation rerun on Windows 11 / Python 3.11.9 / NumPy 2.4.6:
python -m pytest -q: 186 passed, 3 expected failures, 3 subtests passed.python -m doctest README.rst: passed.git diff --check: passed.AI assistance was used to prepare and verify this patch. The archived package's wider Linux/interpreter/build checks were not rerun here. This PR is ready for maintainer review; upstream CI remains to be assessed.