Repository navigation
Conversation
ttk.OptionMenu invokes its command callback with the selected string value (set_menu passes val from *values), not a StringVar. Match the annotation to tkinter.OptionMenu, which already uses str.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
|
Please remove the tests. In typeshed, we only add regression tests for functions and classes which are known to have caused complex problems in the past, or where stubs are difficult to get right. 100% test coverage for typeshed is neither necessary nor desirable, as it would lead to code duplication. See |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16657
ttk.OptionMenucurrently typescommandasCallable[[tkinter.StringVar], object] | None, but at runtime the callback is invoked with the selected string value, not theStringVar. In CPython'stkinter/ttk.py,set_menudoes:where
valcomes from*values(strings). So a validCallable[[str], object]handler is wrongly rejected by the stub.tkinter.OptionMenualready annotatescommandasCallable[[str], object] | None; this change makesttk.OptionMenuconsistent (both the 3.14+ and the older signature).Tests
Added an
OptionMenucase tostdlib/@tests/test_cases/check_tkinter.pyfor bothtkinter.OptionMenuandtkinter.ttk.OptionMenu.Validation (mypy 2.4.0,
--custom-typeshed-dir .):error: Argument "command" to "OptionMenu" has incompatible type "Callable[[str], None]"; expected "Callable[[StringVar], object] | None" [arg-type]check_tkinter.pypasses clean under both--python-version 3.14and--python-version 3.12.