Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

gh-150467: Fix linking python3.dll and python3t.dll with ASan on Windows #160992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ck0i wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −2
Open

gh-150467: Fix linking python3.dll and python3t.dll with ASan on Windows #160992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fd9307
gh-150467: Fix linking python3.dll and python3t.dll with ASan on Windows
ck0i Oct 31, 2026
d04b81a
Drive the python3 DLL entry point from EnableASAN only
ck0i Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-150467: Fix linking python3.dll and python3t.dll with ASan on Windows 
The stable ABI forwarder DLLs are linked with /NOENTRY, so nothing pulls
in the CRT. With AddressSanitizer enabled, the linker adds the ASan
runtime thunk library, which needs the CRT, and the link fails with
unresolved symbols. Keep the default CRT entry point for these DLLs
when building with ASan.
  • Loading branch information
@ck0i
ck0i committed Oct 31, 2026
commit 0fd93073c26b87a29ef76c36c7015f3116676610
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2026-10-30-23-16-35.gh-issue-150467.qMGY7M.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix linking ``python3.dll`` and ``python3t.dll`` on Windows when building with
AddressSanitizer.
8 changes: 8 additions & 0 deletions PCbuild/pyproject.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@
<SupportSigning Condition="'$(Configuration)' == 'Debug'">false</SupportSigning>
<SupportSigning Condition="'$(ConfigurationType)' == 'StaticLibrary'">false</SupportSigning>
<LinkIncremental Condition="$(Configuration) != 'Debug'">false</LinkIncremental>

<!--
AddressSanitizer may be enabled with the EnableASAN property or through the
_CL_ and _LINK_ environment variables, so check all of them.
-->
<PyUsingAsan Condition="'$(PyUsingAsan)' == '' and '$(EnableASAN)' == 'true'">true</PyUsingAsan>
<PyUsingAsan Condition="'$(PyUsingAsan)' == '' and $(_CL_.ToLowerInvariant().Contains('fsanitize=address'))">true</PyUsingAsan>
<PyUsingAsan Condition="'$(PyUsingAsan)' == '' and $(_LINK_.ToLowerInvariant().Contains('inferasanlibs'))">true</PyUsingAsan>
</PropertyGroup>

<PropertyGroup Condition="$(TargetExt) != ''">
Expand Down
6 changes: 5 additions & 1 deletion PCbuild/python3dll.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@
<BufferSecurityCheck>false</BufferSecurityCheck>
</ClCompile>
<Link>
<NoEntryPoint>true</NoEntryPoint>
<!--
The ASan runtime thunks need the CRT to be initialized, so keep the
default entry point when building with AddressSanitizer.
-->
<NoEntryPoint Condition="$(PyUsingAsan) != 'true'">true</NoEntryPoint>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down
6 changes: 5 additions & 1 deletion PCbuild/python3tdll.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@
<BufferSecurityCheck>false</BufferSecurityCheck>
</ClCompile>
<Link>
<NoEntryPoint>true</NoEntryPoint>
<!--
The ASan runtime thunks need the CRT to be initialized, so keep the
default entry point when building with AddressSanitizer.
-->
<NoEntryPoint Condition="$(PyUsingAsan) != 'true'">true</NoEntryPoint>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down
Loading