Repository navigation
gh-78327: Fix buildbot failures on Windows Clang - #159936
Merged
Merged
Conversation
Member
Author
|
!buildbot .+Windows.+Clang |
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 091345c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F159936%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows compilers,
PyObject_HashNotImplementedis loaded from a local thunk and not the real address table, sotype_readycan't check iftp_hash == PyObject_HashNotImplementedand thus cannot set__hash__toNone. This is very annoying.I thought this was fixed by moving the initialization to runtime (which does indeed seem to fix this on MSVC), but it seems that on Clang, the initializer is loaded statically if possible, thus loading the wrong address for
PyObject_HashNotImplemented.