Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

gh-142654: show the clear error message when sampling on an unknown PID #142655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 10 commits into from
Dec 17, 2025
Merged

gh-142654: show the clear error message when sampling on an unknown PID #142655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7024bd1
gh-142654: show the clear error message when sampling on an unknown PID
kemingy Dec 13, 2025
b1a5082
only catch the RuntimeError, leave the PermissionError for downstream
kemingy Dec 13, 2025
cfea35b
catch the PermissionError for macOS
kemingy Dec 13, 2025
ab9c0c6
check if the pid is running before attaching
kemingy Dec 15, 2025
a1c66e5
resolve conflict
kemingy Dec 15, 2025
0a1f140
Merge branch 'main' into gh-142654
kemingy Dec 15, 2025
dcad05a
fix sampling test failure due to the _is_process_running check
kemingy Dec 15, 2025
4d55401
add custom sampling errors
kemingy Dec 16, 2025
5b5ad2f
use os.kill(pid, 0) for all the posix OS
kemingy Dec 16, 2025
7b4bd69
preserve tracebacks, account for permission error, small fixes
pablogsal Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
preserve tracebacks, account for permission error, small fixes
  • Loading branch information
@pablogsal
pablogsal committed Dec 17, 2025
commit 7b4bd6990ec5c65f9dad2906fe142ccab3dbfc1a
4 changes: 0 additions & 4 deletions Lib/profiling/sampling/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
class SamplingProfilerError(Exception):
"""Base exception for sampling profiler errors."""

class SamplingPermissionError(SamplingProfilerError):
def __init__(self):
super().__init__(f"Insufficient permission to access process.")

class SamplingUnknownProcessError(SamplingProfilerError):
def __init__(self, pid):
self.pid = pid
Expand Down
5 changes: 4 additions & 1 deletion Lib/profiling/sampling/sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(self, pid, sample_interval_usec, all_threads, *, mode=PROFILING_MOD
try:
Comment thread
pablogsal marked this conversation as resolved.
Resolved
self.unwinder = self._new_unwinder(native, gc, opcodes, skip_non_matching_threads)
except RuntimeError as err:
raise SystemExit(err)
raise SystemExit(err) from err
# Track sample intervals and total sample count
self.sample_intervals = deque(maxlen=100)
self.total_samples = 0
Expand Down Expand Up @@ -278,6 +278,9 @@ def _is_process_running(pid):
return True
except ProcessLookupError:
return False
except PermissionError:
# EPERM means process exists but we can't signal it
return True
elif sys.platform == "win32":
try:
_remote_debugging.RemoteUnwinder(pid)
Expand Down
Loading