Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

gh-60107: avoid io.RawIOBase.read from reading into a temporary bytearray #138616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taskevich wants to merge 9 commits into from
Closed

gh-60107: avoid io.RawIOBase.read from reading into a temporary bytearray #138616

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
974cc01
allocate a bytes object directly instead and manually construct a wri…
taskevich Sep 7, 2025
b44bec9
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 7, 2025
897e813
gh-60107: gh-138616: Minor code changes
taskevich Sep 7, 2025
77e3875
Merge branch 'direct-read-bytes' of https://github.com/taskevich/cpyt…
taskevich Sep 7, 2025
2351f34
gh-60107: Change blurb_it
taskevich Sep 7, 2025
c671122
Update Misc/NEWS.d/next/C_API/2025-09-07-10-52-09.gh-issue-60107.dhcb…
taskevich Sep 7, 2025
5396b1c
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 7, 2025
23cd0ff
Deleted incorrect news from C_API
taskevich Sep 7, 2025
905b3ec
gh-60107: Tests for readinto
taskevich Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-60107: gh-138616: Minor code changes
  • Loading branch information
@taskevich
taskevich committed Sep 7, 2025
commit 897e8134ce2cf1e56317534898b92f8424bcf879
12 changes: 5 additions & 7 deletions Modules/_io/iobase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ static PyObject *
_io__RawIOBase_read_impl(PyObject *self, Py_ssize_t n)
/*[clinic end generated code: output=6cdeb731e3c9f13c input=b6d0dcf6417d1374]*/
{
PyObject *b, *res;
PyObject *b, *res, *mv;

if (n < 0) {
return PyObject_CallMethodNoArgs(self, &_Py_ID(readall));
Expand All @@ -931,7 +931,7 @@ _io__RawIOBase_read_impl(PyObject *self, Py_ssize_t n)
if (b == NULL)
return NULL;

PyObject *mv = PyMemoryView_FromMemory(PyBytes_AS_STRING(b), n, PyBUF_WRITE);
mv = PyMemoryView_FromMemory(PyBytes_AS_STRING(b), n, PyBUF_WRITE);
if (mv == NULL) {
Py_DECREF(b);
return NULL;
Expand All @@ -952,11 +952,9 @@ _io__RawIOBase_read_impl(PyObject *self, Py_ssize_t n)
return NULL;
}

if (n != PyBytes_GET_SIZE(b)) {
if (_PyBytes_Resize(&b, n) < 0) {
Py_DECREF(b);
return NULL;
}
if (_PyBytes_Resize(&b, n) < 0) {
Py_DECREF(b);
return NULL;
}

return b;
Expand Down