Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

GH-101588: Deprecate pickle/copy/deepcopy support in itertools #104965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 7 commits into from
May 26, 2023
Merged

GH-101588: Deprecate pickle/copy/deepcopy support in itertools #104965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b6aa77
Add deprecations for itertool pickle support.
rhettinger May 26, 2023
c24e293
Limit category to a DeprecationWarnings
rhettinger May 26, 2023
1687005
Expand warning message to cover copy and deepcopy as well
rhettinger May 26, 2023
ae7f17b
Add whatsnew entry
rhettinger May 26, 2023
4fefb7e
Return NULL instead of None. Add third pass to check warning-to-error…
rhettinger May 26, 2023
8943817
Minor wording tweak
rhettinger May 26, 2023
8b56c33
Merge branch 'main' into itertool_pickle_deprecation
rhettinger May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return NULL instead of None. Add third pass to check warning-to-error… 
… promotion.
  • Loading branch information
@rhettinger
rhettinger committed May 26, 2023
commit 4fefb7ee622fc90ffb7c0c12202f44e17d114759
12 changes: 9 additions & 3 deletions Lib/test/test_itertools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,22 @@
import warnings

def pickle_deprecated(testfunc):
""" Run the test twice. On the first pass, verify that a
Deprecation Warning is raised. On the second pass, run
normally but with DeprecationWarnings temporarily disabled.
""" Run the test three times.
First, verify that a Deprecation Warning is raised.
Second, run normally but with DeprecationWarnings temporarily disabled.
Third, run with warnings promoted to errors.
"""
def inner(self):
with self.assertWarns(DeprecationWarning):
testfunc(self)
with warnings.catch_warnings():
warnings.simplefilter("ignore", category=DeprecationWarning)
testfunc(self)
with warnings.catch_warnings():
warnings.simplefilter("error", category=DeprecationWarning)
with self.assertRaises((DeprecationWarning, AssertionError, SystemError)):
testfunc(self)

return inner

maxsize = support.MAX_Py_ssize_t
Expand Down
2 changes: 1 addition & 1 deletion Modules/itertoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class itertools.pairwise "pairwiseobject *" "clinic_state()->pairwise_type"
PyExc_DeprecationWarning, \
"Itertool pickle/copy/deepcopy support " \
"will be removed in a Python 3.14.", 1) < 0) { \
Py_RETURN_NONE; \
return NULL; \
}

/* batched object ************************************************************/
Expand Down