Improve NameError error suggestion for instances

If we are in a method and a NameError is raised for the name X, first check if X is an attribute of the instance as self.X is likely more common than whatever closest match we find in the scope.

PR: gh-99139: Improve NameError error suggestion for instances #99140

pythongh-99139: Improve NameError error suggestion for instances

This is great! I learnt C++ before Python so I used to forget self all the time when I first started programming in Python. Thank you!

gh-99139: Improve NameError error suggestion for instances (#99140)

Looks awesome! Lots of begginers going to love that!

What about a case like:

class Some:
   x = 1
   @classmethod 
   def method(cls):
       x + 2  # Should be cls.x

Do we care to support it? 🤔

Looks awesome! Lots of begginers going to love that!

What about a case like:
class Some:

   x = 1

   @classmethod 

   def method(cls):

       x + 2  # Should be cls.x
Do we care to support it? 🤔

Thanks for the proposal!

I will consider it but is unlikely that will happen as we are not interested in supporting all possible variations of this, specially since the name of the variable here (cls) is less standardised than "self" and is less common.

Also, this will force us to distinguish the type of function to avoid inspecting random variables called "cls".

Thanks for this, and improving error messages in general!

Navigation Menu

Repository navigation

Improve NameError error suggestion for instances #99139

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

📋 Server Request & Proxy Logs

⚙️ Pengaturan Proxy Target

Improve NameError error suggestion for instances #99139

Description

Activity

hauntsaninja commented on Nov 6, 2022

sobolevn commented on Nov 6, 2022

pablogsal commented on Nov 6, 2022

EwoutH commented on Nov 7, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions