Repository navigation
Use instances for index filtering from callbacks. - #1171
Merged
Merged
Conversation
We’re going to still pass in the `:classes` option for the moment, for the sake of anyone who’s got a custom IndexSet that relies on that option when managing callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by discussions in #1166, this PR changes the IndexSet class to accept
:instancesalongside the:classesoption, which could allow custom subclasses of IndexSet to filter returned indices to a subset as determined by the provided instances.In particular, if you're sharding your indices, you can return just the specific shard of indices for the instance, rather than all shards:
While it's not necessary moving forward, I'm still passing through the
:classesoption for anyone who's got a custom IndexSet class that depends on that.