Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

Test that BCL Types work with NodaTime plugin activated - #1532

Open
davidroth wants to merge 5 commits into
npgsql:mainfrom
davidroth:1490-tests
Open

Test that BCL Types work with NodaTime plugin activated#1532
davidroth wants to merge 5 commits into
npgsql:mainfrom
davidroth:1490-tests

Conversation

@davidroth

@davidroth davidroth commented Oct 12, 2020

Copy link
Copy Markdown

Run BuiltInDataTypesNpgsqlTest again with the NodaTime plugin activated to verify that all BCL date/time types are properly supported.

Closes #1490

@davidroth
Run BuiltInDataTypesNpgsqlTest again with the NodaTime plugin activat…
01874ea 
…ed to verify that all BCL date/time types are properly supported.

Closes npgsql#1490
@davidroth

davidroth commented Oct 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

@roji

Npgsql.EntityFrameworkCore.PostgreSQL.BuiltInDataTypesNpgsqlTest.Object_to_string_conversion fails on my machine:

image

Edit: I guess this is because my local Postgres db might use a different culture. Can this be enforced in the test-suite (e.x. by setting the culture when scaffolding the test db)?

@davidroth davidroth changed the title Test that BCL Types work with NodaTime plugin activated WIP: Test that BCL Types work with NodaTime plugin activated Oct 12, 2020
@davidroth davidroth closed this Oct 12, 2020
@davidroth davidroth reopened this Oct 19, 2020
@davidroth davidroth changed the title WIP: Test that BCL Types work with NodaTime plugin activated Test that BCL Types work with NodaTime plugin activated Oct 19, 2020
davidroth
davidroth commented Oct 19, 2020
View reviewed changes
Comment thread Directory.Build.targets
<EFCoreVersion>5.0.0-rc.1.20451.13</EFCoreVersion>
<MicrosoftExtensionsVersion>5.0.0-rc.1.20451.14</MicrosoftExtensionsVersion>
<NpgsqlVersion>5.0.0-ci.20201003T171056</NpgsqlVersion>
<NpgsqlVersion>5.0.0-ci.20201017T090100</NpgsqlVersion>

@davidroth davidroth Oct 19, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to update to pull these changes in.

davidroth
davidroth commented Oct 19, 2020
View reviewed changes
Comment thread test/EFCore.PG.FunctionalTests/BuiltInDataTypesNpgsqlTest.cs
: base(fixture)
{
Fixture.TestSqlLoggerFactory.Clear();
//Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);

@davidroth davidroth Oct 19, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment copied over from line 28 in main branch. Should I remove it?

@roji

roji commented Oct 21, 2020

Copy link
Copy Markdown
Member

@davidroth sorry I haven't been more reactive with all this work, am busy with other stuff... Promise to come back to this in a couple days and push it through for 5.0.

@roji

roji commented Nov 3, 2020

Copy link
Copy Markdown
Member

@davidroth am under pretty massive workload at the moment, with the 5.0 release coming up. Is there anything that isn't purely-test related, i.e. are we sure that the actual support works? If this is just about adding tests, we can always do that after 5.0 is released.

@davidroth

davidroth commented Nov 4, 2020

Copy link
Copy Markdown
Author

@davidroth am under pretty massive workload at the moment, with the 5.0 release coming up. Is there anything that isn't purely-test related, i.e. are we sure that the actual support works? If this is just about adding tests, we can always do that after 5.0 is released.

@roji This MR is only for adding tests. The tests revealed a bug first, which has already been fixed. Beside from that, I am confident, that the current support works as expected.

@roji

roji commented Nov 4, 2020

Copy link
Copy Markdown
Member

Thanks @davidroth, I'll look into this once things quiet down a bit.

@roji
roji force-pushed the main branch 9 times, most recently from 79fae3a to f894de9 Compare February 16, 2026 16:01
@roji
roji force-pushed the main branch 2 times, most recently from 75c2ea9 to d038259 Compare February 25, 2026 14:25
@roji roji mentioned this pull request Oct 21, 2026
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji Awaiting requested review from roji
@YohDeadfall YohDeadfall Awaiting requested review from YohDeadfall

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update NodaTimeTests and add BCL types to verify BCL type handler forwarding

2 participants

@davidroth @roji