Repository navigation
Update strict_min_version in the browser_specific_settings example - #46329
Open
monarchsofchaos004-gif wants to merge 2 commits into
Open
monarchsofchaos004-gif wants to merge 2 commits into
monarchsofchaos004-gif wants to merge 2 commits into
Conversation
monarchsofchaos004-gif
requested review from
kzar
and removed request for
a team
October 30, 2026 01:15
kzar
requested changes
Oct 30, 2026
kzar
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, I agree this is worth updating 👍 . I have left a few comments.
Comment on lines
+45
to
+48
| "strict_min_version": "140.0" | ||
| }, | ||
| "gecko_android": { | ||
| "strict_min_version": "142.0" |
Member
There was a problem hiding this comment.
Suggested change
| "strict_min_version": "140.0" | |
| }, | |
| "gecko_android": { | |
| "strict_min_version": "142.0" | |
| "strict_min_version": "140.0" | |
| } |
Member
There was a problem hiding this comment.
Changing this to 140 looks right to me, as you pointed out the example also requires data_collection_permissions which is listed as requiring 140.
There was a problem hiding this comment.
Applied, thanks.
| Example with all possible keys. Note that most extensions omit `strict_max_version` and `update_url`. | ||
|
|
||
| ```json | ||
| "browser_specific_settings": { |
Member
There was a problem hiding this comment.
How about updating this example too?
- I'd rather add the Android key here that you suggested for the other example, since this one is listed as being for "all possible keys", and since this example follows notes about the Android key.
- I figure the versions are likely wrong here too, could you look into that and see what you think?
There was a problem hiding this comment.
Done, I moved the gecko_android key into this example and updated the versions:
gecko.strict_min_versionis now128.0. The note above says 128.0 is the oldest non-ESR version that can still verify signatures and receive updates, and this example usesupdate_url. The old42.0–50.*range doesn't install on any current release.gecko_androiduses the same128.0minimum (the key itself needs Firefox for Android 113+, and there is no ESR on Android).strict_max_versionis the current release,159.*, in both blocks. It will age like50.*did, so if you'd prefer a different value, or no max in the Android block, I'm happy to change it.- For Safari,
20isn't a real version (Safari went from 18 to 26), so I changed the max to26.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first example on the
browser_specific_settingspage declaresdata_collection_permissionstogether with"strict_min_version": "58.0". That combination is not valid:data_collection_permissionsrequires Firefox 140, so AMO reports "Manifest key not supported by the specified minimum Firefox version" for such a manifest.This PR:
gecko.strict_min_versionto140.0in that first example;gecko_androidkey and brings the versions up to date (details in the review thread).Motivation
Readers copy these examples into their manifests and then hit signing warnings. Fixes #44136.
Additional details
Versions come from browser-compat-data (
data_collection_permissions: Firefox 140, Firefox for Android 142;gecko_android: Firefox for Android 113) and the root-certificate note on this page (128.0).