Repository navigation
Conversation
…ls.wraps When decorators like SetParseFn and SetParseFns are applied to functions wrapped with functools.wraps, copying existing parse_fns and metadata dictionaries prevents mutating the underlying function's metadata in place. Fixes google#728. Signed-off-by: Aryan Sachin <aryansachinixd@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported in #728, decorating a wrapper created with \unctools.wraps\ using \SetParseFn\ or \SetParseFns\ unexpectedly mutates how the original wrapped function parses its arguments. Because \unctools.wraps\ copies the function's attribute dictionary, the underlying Fire metadata dictionary is shared, and updating it in place affects both wrapper and wrapped functions.
Solution
amed\ dictionary so updates to named parsers do not mutate shared dictionaries in place.
Fixes #728.