Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fallback returns the macOS SDK version instead of the Xcode version, causing compatibility checks and diagnostics to use the wrong product version.
1 open issue
1 file not reviewed
lib/entry-points.js: Excluded by your content exclusion settings
What changed in this PR
Adds an xcrun-based fallback to Xcode version detection, extending the platform compatibility checks introduced in #4221 for traced CodeQL analysis.
Changes:
- Separates symlink-based detection from the new command-based fallback.
- Makes Xcode version detection asynchronous and updates its caller.
- Adds tests for command output, failures, and fallback execution.
| File | Description |
|---|---|
src/platform.ts |
Adds the command-based fallback and asynchronous detection wrapper. |
src/platform.test.ts |
Updates symlink tests and adds fallback coverage. |
src/languages/traced.ts |
Awaits Xcode detection before checking compatibility. |
Review effort: Balanced (auto)
mbg
force-pushed
the
mbg/macos27/xcode-detection
branch
from
October 30, 2026 14:50
d4d1085 to
41e631a
Compare
mbg
force-pushed
the
mbg/macos27/xcode-detection
branch
from
October 30, 2026 14:59
41e631a to
be54d79
Compare
henrymercer
reviewed
Oct 30, 2026
…tsTracedAnalysis`
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the macOS version-detection fallback changes.
No open issues 🎉
1 resolved since last review
1 file not reviewed
lib/entry-points.js: Excluded by your content exclusion settings
Review effort: Balanced (auto)
henrymercer
reviewed
Oct 30, 2026
henrymercer
left a comment
Contributor
There was a problem hiding this comment.
Two small things, otherwise LGTM
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-on to #4221 which adds a fallback for the Xcode version detection which calls out to
xcrun.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist