Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the nested class-like declaration name-binding update.
No open issues 🎉
What changed in this PR
Updates unified name binding to recognize all nested class-like declarations as static members, extending support beyond classes.
Changes:
- Explicitly includes
ClassLikeDeclarationin static-member classification. - Adds Swift regression coverage for qualified access to a nested enum and its case.
| File | Description |
|---|---|
unified/ql/test/library-tests/static-name-binding/test.swift |
Adds a nested enum and checks name binding for A.Enum.empty. |
unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll |
Treats nested class-like declarations as static members. |
Review effort: Max
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It only worked for
classes before "by accident", because they were covered by this logic, which was presumably meant to handle class fields and methods.DCA is good.