Repository navigation
[Copilot Dreams] Avoid incorrect ARM Linux build assumptions - #22947
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| a `//conditions:default`. **There is deliberately no fallback from `linux_arm64` to `linux64`.** If you only care about | ||
| the OS, use `os_select`, which gives Linux the same value on both architectures and has a `posix` shorthand for the | ||
| shared Linux/macOS value. | ||
| a `//conditions:default`. If you only care about the OS, use `os_select`, which gives Linux the same value on both |
Author
There was a problem hiding this comment.
🛠️ Preserve valid ARM Linux choices: The old blanket warning could make Copilot reject a usable Linux value for an ARM Linux build. Macro calls omit an unset ARM-specific branch, leaving the architecture-independent Linux match; rule implementations still reject a missing ARM-specific value.
Contributor
|
@redsun82 I know you've moved area, but since you last edited the lines that it's changing perhaps you will know if this is a reasonable change. |
redsun82
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧠 How this helps Copilot
The old warning could make Copilot wrongly assume generic Linux build values cannot apply to ARM Linux. This correction avoids that blanket assumption for build-definition helpers, while individual build rules still reject a missing ARM-specific value.
Automated details
Source:
curate-memoriesDream, analyzingmainat18b48aac513b.