Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

SSA: Refactor post-update support in DataFlowIntegration. #22914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 7 commits into from
Oct 30, 2026
Merged

SSA: Refactor post-update support in DataFlowIntegration. #22914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
137a568
SSA: Extend signature to cover post-updates.
aschackmull Oct 26, 2026
a15d1a4
SSA: Add missing private annotations.
aschackmull Oct 27, 2026
0706bc9
SSA: Remove superfluous line (see the readWithoutDef consistency check).
aschackmull Oct 27, 2026
263094f
SSA: Insert postupdates in AdjacentSsaRefs calculation.
aschackmull Oct 28, 2026
d5079ef
SSA: Switch DataflowIntegration to use the new post-update api.
aschackmull Oct 28, 2026
51690fd
SSA: Switch consistency counts to strictcount.
aschackmull Oct 29, 2026
f6d51da
C/C++: Fix faulty iterator flow relying on SSA use-use bug.
aschackmull Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImplCommon.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,16 @@ private module IteratorIndirections {
)
}

// A by-value crement result loads the iterator, rather than aliasing its address.
override predicate isAdditionalDereference(Instruction deref, Operand address) {
exists(CallInstruction call |
deref = call and
call.getStaticCallTarget() instanceof Iterator::IteratorCrementMemberOperator and
not call.getResultType() instanceof Cpp::ReferenceType and
address = call.getThisArgumentOperand()
)
}

override predicate isAdditionalConversionFlow(Operand opFrom, Instruction instrTo) {
// This is a bit annoying: Consider the following snippet:
// ```
Expand Down Expand Up @@ -255,11 +265,11 @@ private module IteratorIndirections {
store.getDestinationAddress() = var
)
or
// A call to `operator++` or `operator--` is the iterator equivalent version of a
// pointer arithmetic instruction.
// A reference-returning `operator++` or `operator--` preserves the iterator's address.
exists(CallInstruction call |
instrTo = call and
call.getStaticCallTarget() instanceof Iterator::IteratorCrementMemberOperator and
call.getResultType() instanceof Cpp::ReferenceType and
opFrom = call.getThisArgumentOperand()
)
}
Expand Down
10 changes: 0 additions & 10 deletions rust/ql/test/query-tests/diagnostics/SsaConsistencyCounts.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +0,0 @@
| Definition cannot reach a read | 0 |
| End of a basic block can be reached by multiple definitions | 0 |
| Phi has less than 2 immediately prior references | 0 |
| Phi node has less than two inputs | 0 |
| Phi read has less than 2 immediately prior references | 0 |
| Read can be reached from multiple definitions | 0 |
| Read cannot be reached from a definition | 0 |
| Read does not have a prior reference | 0 |
| Read has multiple prior references | 0 |
| Read is not dominated by a definition | 0 |
Loading
Loading