Repository navigation
Rust: Add data flow test for ? in a closure - #22913
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the tail-position ? closure test and expected-output updates.
No open issues 🎉
What changed in this PR
Extends Rust’s closure data-flow tests after #22903 to verify that a tail-position ? preserves normal return-value flow.
Changes:
- Adds a closure test that unwraps nested
Optionvalues and checks flow to a sink. - Updates expected data-flow paths and model output.
| File | Description |
|---|---|
rust/ql/test/library-tests/dataflow/lambdas/main.rs |
Adds the closure ? flow test. |
rust/ql/test/library-tests/dataflow/lambdas/inline-flow.expected |
Records expected paths and the Option::unwrap model. |
Review effort: Max
paldepind
previously approved these changes
Oct 30, 2026
hvitved
force-pushed
the
rust/try-in-closure-test
branch
from
October 30, 2026 13:09
3dfc06a to
540f85b
Compare
paldepind
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22903 follow-up.