Repository navigation
Conversation
ryzhyk
approved these changes
Oct 30, 2026
swanandx
enabled auto-merge
October 30, 2026 18:44
Contributor
|
LGTM. The fix is narrow and correct. A paused reader now releases its
Gates: the PR adds an integration test that fails without the fix. The test showed no flakiness in debug, release or loaded runs. It also has a guard ( |
A paused Delta reader kept its reader permit. A connector that voted to commit is not drained, so it stays paused, and a connector that still needs a permit waits forever. Both catchup and always modes hang. Co-authored-by: Anand Raman <anand.raman@feldera.com> Signed-off-by: Swanand Mulay <73115739+swanandx@users.noreply.github.com>
swanandx
disabled auto-merge
October 30, 2026 19:08
swanandx
added this pull request to the merge queue
Oct 30, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #7746
Describe Manual Test Plan
A paused Delta reader now gives up its reader permit until it resumes, so a connector that has voted to commit can no longer block one that has not. The repro from the issue now runs in catchup and always mode; both fail without the fix and pass with it.
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes
None.