Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

fix: Break event timestamp ties by created timestamp in Milvus write batches #7084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiwidi wants to merge 2 commits into
base: master
Choose a base branch
from
+102 −4
Open

fix: Break event timestamp ties by created timestamp in Milvus write batches #7084

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
050c297
fix: Break event timestamp ties by created timestamp in Milvus write …
jiwidi Oct 28, 2026
411f2e3
test: Cover a Milvus write batch with several entities
jiwidi Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: Cover a Milvus write batch with several entities 
Signed-off-by: jiwidi <fhjaime96@gmail.com>
  • Loading branch information
@jiwidi
jiwidi committed Oct 28, 2026
commit 411f2e3c57081f61b2b979f5588cc341064dc047
23 changes: 23 additions & 0 deletions sdk/python/tests/unit/infra/online_store/test_milvus_online_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,29 @@ def test_write_batch_keeps_the_newest_row_per_entity(
assert rows_read[0]["city"].string_val == expected_city


def test_write_batch_keeps_one_row_per_entity(tmp_path: Path) -> None:
store = MilvusOnlineStore()
config = _lite_config(tmp_path)
fv = _scalar_feature_view()
now = datetime(2024, 1, 1, tzinfo=timezone.utc)

store.online_write_batch(
config,
fv,
[
(_entity_key(1), {"city": ValueProto(string_val="Oslo")}, now, now),
(_entity_key(2), {"city": ValueProto(string_val="Rome")}, now, now),
],
progress=None,
)

rows = _read(store, config, fv, [1, 2], ["city"])
assert [row["city"].string_val for row in rows if row is not None] == [
"Oslo",
"Rome",
]


@patch(f"{MILVUS_MODULE}.MilvusClient")
def test_placeholder_vector_is_indexed_and_valid(mock_client_cls: MagicMock) -> None:
mock_client = _mock_client(mock_client_cls, has_collection=False)
Expand Down
Loading