Repository navigation
Conversation
…line store A partition key (feast-dev#6940) comes with two collection settings that Milvus only accepts when the collection is created: the number of partitions, and partition key isolation, which makes a search filtered on the key scan only that key's data. num_partitions and partition_key_isolation are passed to create_collection for feature views that have a partition key. They are ignored for other feature views. When unset nothing is sent, so Milvus keeps its defaults. Signed-off-by: jiwidi <fhjaime96@gmail.com>
This was referenced Oct 28, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
+ Coverage 50.97% 51.00% +0.02%
==========================================
Files 455 455
Lines 56994 57011 +17
Branches 8321 8325 +4
==========================================
+ Hits 29055 29080 +25
+ Misses 25954 25946 -8
Partials 1985 1985
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#6940 added partition keys. Milvus has two per-collection settings that go with them and that can
only be set when the collection is created: the number of partitions, and
partition key isolation,
which makes a search filtered on the key scan only that key's data. Like
key_ttl_secondsin theRedis store, they are settings the store applies when it creates data and cannot change later.
num_partitionspartition_key_isolationpartitionkey.isolationproperty of a new collection that has a partition key. Milvus supports it with the HNSW index.Both are ignored for feature views without a partition key, and both only apply when Feast creates
the collection, like
partition_keyitself. When unset nothing is sent, so Milvus keeps itsdefaults. Milvus Lite ignores
num_partitions.Which issue(s) this PR fixes:
N/A
Checks
git commit -s)Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit (mocked client): both settings are sent for a feature view with a partition key and not
for one without; nothing is sent when unset;
num_partitions: 0is rejected.Server: the collection reports the partition count and the isolation property, and a filtered
search returns only that tenant's rows.
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). The server test in
sdk/python/tests/integration/online_store/test_milvus_remote.pypasses against a localMilvus 3.0.2 server. The existing Milvus unit and server tests pass unchanged.
Misc
Part of a stack that adds to the Milvus online store the update and delete functionality the Redis
online store has, following #6882, #6895, #6917, #6921 and #6940. The other PRs of the stack are
#7082 (row deletion) and #7084 (tie-break in write batches).
mutation_timeoutand a schema mismatch check follow once these merge.