Repository navigation
Fix lazy GenBank loading of multiple records - #1159
Open
vera-rubin wants to merge 1 commit into
Open
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With multiple records in a GenBank file,
readGenbankDNASequence(file, true)returns the first record's DNA for later accessions. Two records containingAB123456(AAAAAA) andAB123457(CCCCCC) both returnAAAAAA, even though the helper documents loading each sequence by accession.We now pass each record's character offset to the sequence creator, preserving it across parser lookahead and line endings. We added a regression test for eager versus lazy loading and consecutive
process(1)calls, and the reader and writer tests pass.Reproduced on base commit
8f151db1d376ed0311979bd6bc2131f0eea11c1a.— ChipLab