You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What's the intended meaning of PDBHeader.getDescription? It is populated in mmCIF with the _struct_keywords.pdbx_keywords field, the same as getClassification() (e.g. lyase, oxidase, etc). It seems to be unused in PDB files. It's also modified in a couple places for partial structures, e.g. "subset of 1ABC".
I propose to create a new method getKeywords() to store the data on _struct_keywords.pdbx_keywords and leave the getDescription() method to maintain the other use cases (additional information). I will also document the two.
After looking a bit more into these methods, it seems that the main problem is their documentation, as they seem to be differently used when parsing from PDB or mmCIF formats. I think this could be something we can check when we test for consistency in #679, so I it will not require API changes and we can leave it for later.
Activity
lafita commentedon Mar 11, 2018
It seems that this field is quite general in use.
I propose to create a new method
getKeywords()to store the data on_struct_keywords.pdbx_keywordsand leave thegetDescription()method to maintain the other use cases (additional information). I will also document the two.lafita commentedon Mar 12, 2018
After looking a bit more into these methods, it seems that the main problem is their documentation, as they seem to be differently used when parsing from PDB or mmCIF formats. I think this could be something we can check when we test for consistency in #679, so I it will not require API changes and we can leave it for later.
aalhossary commentedon Oct 31, 2021
related to #946