Repository navigation
PostgreSQL: Support BEGIN ATOMIC procedure bodies - #2773
Open
LucaCappelletti94 wants to merge 2 commits into
Open
LucaCappelletti94 wants to merge 2 commits into
LucaCappelletti94 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2773 +/- ##
==========================================
+ Coverage 82.66% 82.68% +0.01%
==========================================
Files 42 42
Lines 35660 35674 +14
Branches 35660 35674 +14
==========================================
+ Hits 29480 29498 +18
+ Misses 2659 2658 -1
+ Partials 3521 3518 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sabir-akhadov-localstack
approved these changes
Oct 30, 2026
| } | ||
|
|
||
| #[test] | ||
| fn parse_create_procedure_begin_atomic() { |
Contributor
There was a problem hiding this comment.
parse_create_procedure has no dialect gating and the other CREATE PROCEDURE tests live in sqlparser_common.rs, so this one could go there with all_dialects(); every dialect round-trips these inputs.
LucaCappelletti94
force-pushed
the
upstream/begin-atomic-procedure-body
branch
from
October 30, 2026 21:08
637067e to
bd7af2f
Compare
LucaCappelletti94
force-pushed
the
upstream/begin-atomic-procedure-body
branch
2 times, most recently
from
October 31, 2026 08:30
bce24b8 to
22ea3a6
Compare
LucaCappelletti94
force-pushed
the
upstream/begin-atomic-procedure-body
branch
from
October 31, 2026 09:01
22ea3a6 to
26e459d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE PROCEDURE p() LANGUAGE sql BEGIN ATOMIC INSERT INTO t VALUES (1); ENDfailed withExpected: AS, found: BEGINunder bothPostgreSqlDialectandGenericDialect. PostgreSQL accepts the same SQL-standard body for procedures as for functions (https://www.postgresql.org/docs/current/sql-createprocedure.html), as raised in the review of #2728.