Repository navigation
fix(@schematics/angular): add a TODO for negated expectAsync matchers in refactor-jasmine-vitest - #34619
Open
MeAkib wants to merge 1 commit into
Open
fix(@schematics/angular): add a TODO for negated expectAsync matchers in refactor-jasmine-vitest#34619MeAkib wants to merge 1 commit into
MeAkib wants to merge 1 commit into
Conversation
… in refactor-jasmine-vitest Negated async matchers such as `expectAsync(promise).not.toBeResolved()` were left unchanged without a TODO comment, so the migrated test failed at runtime because `expectAsync` does not exist in Vitest. Negated async matchers have no exact Vitest equivalent, so add the existing unsupported `expectAsync` matcher TODO comment to them.
There was a problem hiding this comment.
Code Review
This pull request updates the Jasmine-to-Vitest refactoring tool to detect negated async matchers (such as '.not.toBeResolved()') during expectAsync transformations. Since these matchers do not have a direct equivalent in Vitest, the tool now records a TODO comment prompting manual migration. A corresponding unit test has also been added to verify this behavior. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negated async matchers such as
expectAsync(promise).not.toBeResolved()were left unchanged without a TODO comment, so the migrated test failed at runtime becauseexpectAsyncdoes not exist in Vitest.Negated async matchers have no exact Vitest equivalent, so add the existing unsupported
expectAsyncmatcher TODO comment to them.