Repository navigation
Conversation
…quested version Modern yarn returns the manifest of the latest version instead of an error when the requested version or range does not exist (for example, `yarn npm info @angular/core@99.99.99` prints the latest version with exit code 0). As a result, `ng add` and `ng update` could continue with an unrelated version instead of reporting that the requested version does not exist. Return `null` from `getRegistryManifest` when the fetched version does not satisfy the requested version or range.
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where modern yarn returns the latest version instead of throwing an error when a requested package version does not exist. It adds a check in PackageManager.getRegistryManifest to return null if the fetched manifest version does not satisfy the requested version range, and includes corresponding unit tests. Feedback suggests defensively validating manifest.version using valid() before calling satisfies to prevent potential runtime TypeError crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern yarn returns the manifest of the latest version instead of an error when the requested version or range does not exist (for example,
yarn npm info @angular/core@99.99.99prints the latest version with exit code 0). As a result,ng addandng updatecould continue with an unrelated version instead of reporting that the requested version does not exist.Return
nullfromgetRegistryManifestwhen the fetched version does not satisfy the requested version or range.