Enhanced <select>: HTML parser changes by annevk · Pull Request #51626 · WebKit/WebKit

annevk · 2025-10-01T15:42:40Z

`6c7c731`

Enhanced <select>: HTML parser changes
https://bugs.webkit.org/show_bug.cgi?id=299959
rdar://140875257

Reviewed by Ryosuke Niwa.

This implements the parser aspects of
whatwg/html#10548 behind a flag. The old code
path continues to be tested through our legacy HTML parser test suite.

This does not yet implement new logic for the <select>, <optgroup>,
<option>, and <hr> classes to account for the fact that <optgroup>,
<option>, and <hr> can now appear as descendants and as such this is
only useful for testing.

Remove fast/parser/input-textarea-inside-select-element.html test as it
was duplicative of both the legacy HTML parser test suite and WPT
coverage.

(Until these recent <select> changes were made the legacy HTML parser
test suite was synchronized with the WPT test suite. We'll remove it
once it's easier to add HTML parser tests on the WPT side.)

Canonical link: https://commits.webkit.org/300998@main

70add99

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		❌ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	~~🛠 jsc-armv7~~
	✅ 🛠 tv-sim		~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-10-01T15:42:46Z

EWS run on previous version of this PR (hash a348d06)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-10-02T10:36:13Z

EWS run on previous version of this PR (hash 010efba)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

rniwa · 2025-10-02T16:53:07Z

@@ -70,6 +70,8 @@ inline bool isScopeMarker(HTMLStackItem& item)
    case SVG::desc:
    case SVG::title:
        return true;
+    case HTML::select:
+        return item.node().document().settings().htmlEnhancedSelectParsingEnabled();


Hm... it's unfortunate that we can't use HTMLParserOptions here.

webkit-early-warning-system · 2025-10-04T10:21:51Z

EWS run on current version of this PR (hash 70add99)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		❌ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	~~🛠 jsc-armv7~~
	✅ 🛠 tv-sim		~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=299959 rdar://140875257 Reviewed by Ryosuke Niwa. This implements the parser aspects of whatwg/html#10548 behind a flag. The old code path continues to be tested through our legacy HTML parser test suite. This does not yet implement new logic for the <select>, <optgroup>, <option>, and <hr> classes to account for the fact that <optgroup>, <option>, and <hr> can now appear as descendants and as such this is only useful for testing. Remove fast/parser/input-textarea-inside-select-element.html test as it was duplicative of both the legacy HTML parser test suite and WPT coverage. (Until these recent <select> changes were made the legacy HTML parser test suite was synchronized with the WPT test suite. We'll remove it once it's easier to add HTML parser tests on the WPT side.) Canonical link: https://commits.webkit.org/300998@main

webkit-commit-queue · 2025-10-04T13:02:07Z

Committed 300998@main (6c7c731): https://commits.webkit.org/300998@main

Reviewed commits have been landed. Closing PR #51626 and removing active labels.

annevk requested review from cdumez and rniwa as code owners October 1, 2025 15:42

annevk self-assigned this Oct 1, 2025

annevk added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Oct 1, 2025

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 1, 2025

annevk removed the merging-blocked Applied to prevent a change from being merged label Oct 2, 2025

annevk force-pushed the eng/Enhanced-select-HTML-parser-changes branch from a348d06 to 010efba Compare October 2, 2025 10:36

rniwa reviewed Oct 2, 2025

View reviewed changes

Comment thread Source/WebCore/html/parser/HTMLTreeBuilder.cpp Outdated

rniwa approved these changes Oct 2, 2025

View reviewed changes

annevk force-pushed the eng/Enhanced-select-HTML-parser-changes branch from 010efba to 70add99 Compare October 4, 2025 10:21

annevk added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Oct 4, 2025

webkit-commit-queue force-pushed the eng/Enhanced-select-HTML-parser-changes branch from 70add99 to 6c7c731 Compare October 4, 2025 13:02

webkit-commit-queue merged commit 6c7c731 into WebKit:main Oct 4, 2025

webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Oct 4, 2025

annevk deleted the eng/Enhanced-select-HTML-parser-changes branch October 4, 2025 13:06

Navigation Menu

Repository navigation

Enhanced <select>: HTML parser changes - #51626

Enhanced <select>: HTML parser changes#51626
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Enhanced-select-HTML-parser-changes

annevk commented Oct 1, 2025 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Oct 1, 2025 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 2, 2025 •

edited

Loading

Uh oh!

rniwa Oct 2, 2025

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 4, 2025 •

edited

Loading

Uh oh!

webkit-commit-queue commented Oct 4, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

📋 Server Request & Proxy Logs

⚙️ Pengaturan Proxy Target

Conversation

annevk commented Oct 1, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

6c7c731

Uh oh!

webkit-early-warning-system commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rniwa Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Oct 4, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

annevk commented Oct 1, 2025 •

edited by webkit-early-warning-system

Loading

`6c7c731`

webkit-early-warning-system commented Oct 1, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 2, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 4, 2025 •

edited

Loading