Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

Match marshal wrapper audit and conversion contracts - #9483

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:py315-marshal-read-audit-20261030
Oct 30, 2026
Merged

Match marshal wrapper audit and conversion contracts#9483
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:py315-marshal-read-audit-20261030

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Emit marshal.loads with an immutable copy of the complete input, and marshal.load with no arguments. Preserve hook exceptions and decode the original buffer after hooks return without holding its borrow during callbacks.
  • Match load's read(0) bytes preflight and error priority; retain its returned object through decoding.
  • Apply truth conversion to allow_code consistently across all four wrappers and return the result of file.write from dump.
  • Restore the existing test_audit.AuditTest.test_marshal using scripts/update_lib migrate, preserving every other test adaptation.

Source comparison: pinned CPython read_object, marshal_load_impl, marshal_loads_impl, and marshal_dump_impl, plus the Clinic argument converters. This does not change the serializer's reference-sharing policy or #9450's external code provenance validation.

Validation

  • Scoped Cargo check, strict Clippy, and CLI build passed.
  • 57 finite observations per engine matched pinned CPython exactly: event payload/type/order, read preflight, hook refusal, post-hook fixed-size input mutation, all four truth-conversion paths, and writer result/exception propagation.
  • An initial strict comparison exposed existing wrapper differences fixed here, and differing FLAG_REF serialization choices. Read-side comparisons now use one retained CPython-produced scalar fixture; serializer byte identity is not claimed. The original failing comparison was retained.
  • Normal configured commit hooks passed.
  • Canonical subprocess tests and whole suites were not run locally; hosted CI is pending.

AI assistance

OpenAI Codex assisted with implementation, CPython source comparison, and validation. The model version was unavailable.

@codex
Match marshal wrapper audit and conversion contracts
0a42ae7 
Emit read-side audit events after argument and file preflight checks, convert allow_code through truth testing, and preserve dump write results. Restore the canonical marshal audit test through update_lib.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] test: cpython/Lib/test/test_sys.py (TODO: 4)
[x] test: cpython/Lib/test/test_syslog.py
[x] test: cpython/Lib/test/test_sys_setprofile.py (TODO: 1)
[x] test: cpython/Lib/test/test_sys_settrace.py
[x] test: cpython/Lib/test/test_audit.py (TODO: 15)
[x] test: cpython/Lib/test/audit-tests.py

dependencies:

dependent tests: (249 tests)

  • sys: regrtestdata test___all__ test__colorize test__locale test__osx_support test_android test_annotationlib test_argparse test_array test_asdl_parser test_ast test_asyncio test_audit test_base64 test_bdb test_bigaddrspace test_bigmem test_binascii test_bisect test_buffer test_builtin test_bytes test_bz2 test_c_locale_coercion test_calendar test_class test_clinic test_cmath test_cmd test_cmd_line test_cmd_line_script test_code test_code_module test_codeccallbacks test_codecs test_collections test_compile test_compileall test_complex test_concurrent_futures test_context test_contextlib test_coroutines test_crossinterp test_csv test_ctypes test_curses test_datetime test_dbm test_dbm_sqlite3 test_decimal test_descr test_dict test_difflib test_dis test_doctest test_docxmlrpc test_dtrace test_dynamic test_dynamicclassattribute test_email test_embed test_ensurepip test_enum test_enumerate test_eof test_epoll test_except_star test_exceptions test_external_inspection test_faulthandler test_fcntl test_file_eintr test_fileinput test_float test_fork1 test_format test_fractions test_frame test_free_threading test_frozen test_functools test_future_stmt test_gc test_generated_cases test_generators test_genericpath test_genexps test_getopt test_glob test_grammar test_gzip test_hash test_hashlib test_http_cookiejar test_httpservers test_importlib test_inspect test_int test_interpreters test_io test_ioctl test_iter test_itertools test_json test_launcher test_list test_listcomps test_locale test_logging test_long test_lzma test_mailbox test_marshal test_math test_memoryview test_metaclass test_mimetypes test_mmap test_monitoring test_msvcrt test_multibytecodec test_multiprocessing_forkserver test_multiprocessing_main_handling test_netrc test_ntpath test_numeric_tower test_opcache test_operator test_optparse test_ordered_dict test_os test_osx_env test_pathlib test_patma test_pdb test_peepholer test_perfmaps test_pickle test_pkg test_pkgutil test_platform test_plistlib test_popen test_posixpath test_print test_profile test_profiling test_property test_pty test_pwd test_py_compile test_pyclbr test_pydoc test_pyexpat test_pyrepl test_quopri test_raise test_range test_re test_readline test_regrtest test_remote_pdb test_repl test_reprlib test_resource test_runpy test_sax test_scope test_script_helper test_select test_selectors test_shutil test_signal test_site test_slice test_smtplib test_socket test_source_encoding test_sqlite3 test_ssl test_stable_abi_ctypes test_startfile test_stat test_statistics test_str test_strftime test_string_literals test_strptime test_strtod test_struct test_subprocess test_support test_sys test_sys_setprofile test_sys_settrace test_sysconfig test_syslog test_tabnanny test_tarfile test_tcl test_tempfile test_termios test_threading test_threading_local test_threadsignals test_time test_timeit test_tkinter test_tomllib test_tools test_trace test_traceback test_tracemalloc test_ttk test_tuple test_type_cache test_type_comments test_types test_typing test_unicode_file test_unicode_file_functions test_unicodedata test_unittest test_urllib test_urllib2 test_urllib2net test_urlparse test_utf8_mode test_uuid test_venv test_wait3 test_wait4 test_wave test_weakref test_webbrowser test_winconsoleio test_winreg test_with test_wsgiref test_xml_etree test_xmlrpc test_xpickle test_zipapp test_zipfile test_zipfile64 test_zipimport test_zipimport_support test_zlib

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowdot youknowdot mentioned this pull request Oct 30, 2026
Merged
@youknowone
youknowone marked this pull request as ready for review October 30, 2026 15:10
@youknowone
youknowone merged commit bbc709e into RustPython:main Oct 30, 2026
21 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-30T15:11:45.343976Z
We couldn’t complete this review. Comment @codex review to try again.		 0a42ae7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youknowdot @youknowone @codex