Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

Fix _interpreters shared and updates argument diagnostics - #9295

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:py315-interpreters-named-argument-errors-20261022
Oct 22, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:py315-interpreters-named-argument-errors-20261022

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

  • Use the Python 3.15 parameter names shared and updates instead of numeric argument labels in dictionary-validation errors.
  • This covers _interpreters.exec, run_string, run_func and set___main___attrs through their existing argument converters.
  • Extracts two native diagnostic literals from Integrate remaining Python 3.15 final runtime and libraries #8954; no Lib or test changes.

Validation

  • Built the default+CAPI debug CLI from current main ad8bd18 plus only this patch.
  • Passed changed-file hooks including rustfmt, VM checks with and without threading, threading test-target compilation, and scoped VM all-target strict Clippy (-D warnings).
  • Ran only the unchanged CommonTests.test_signatures method from CPython 3.15 pin d220409a13b77de7a6c30abe16ea90db01528edc, preserving all five assertions. The external isolation sets id=0 and skips both lifecycle fixtures; the canonical module itself is not executed.
  • Pinned CPython and patched RustPython pass all five assertions. Unpatched main fails at the first expected regex mismatch (argument 3 rather than argument 'shared'); the remaining four assertions are not reached on baseline.
  • Verified native module origin, executable/source hashes and stdlib provenance. Runs use -B, a 120-second timeout, 1 GiB address-space limit and zero core dumps.

This validates early argument errors only, not subinterpreter lifecycle or execution capability. Full interpreter modules and the full workspace/CAPI runtime suite were not run.

Prepared and validated with AI assistance.

Use parameter names in dictionary validation errors to match Python 3.15.

Assisted-by: OpenAI Codex:model-version-unavailable
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between ad8bd18 and e4615f7.

📒 Files selected for processing: 1
  • crates/vm/src/stdlib/_interpreters.rs
+--------------------------------------------------+
| Veni, Vidi, Validavi. I came, I saw, I reviewed. |
+--------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone marked this pull request as ready for review October 22, 2026 09:11
@youknowone
youknowone merged commit 580706f into RustPython:main Oct 22, 2026
21 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T09:14:31.159537Z e4615f7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants