Repository navigation
Fix _interpreters shared and updates argument diagnostics - #9295
Merged
youknowone merged 1 commit intoOct 22, 2026
Merged
youknowone merged 1 commit into
youknowone merged 1 commit into
Conversation
Use parameter names in dictionary validation errors to match Python 3.15. Assisted-by: OpenAI Codex:model-version-unavailable
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Oct 22, 2026
youknowone
marked this pull request as ready for review
October 22, 2026 09:11
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sharedandupdatesinstead of numeric argument labels in dictionary-validation errors._interpreters.exec,run_string,run_funcandset___main___attrsthrough their existing argument converters.Validation
-D warnings).CommonTests.test_signaturesmethod from CPython 3.15 pin d220409a13b77de7a6c30abe16ea90db01528edc, preserving all five assertions. The external isolation setsid=0and skips both lifecycle fixtures; the canonical module itself is not executed.argument 3rather thanargument 'shared'); the remaining four assertions are not reached on baseline.-B, a 120-second timeout, 1 GiB address-space limit and zero core dumps.This validates early argument errors only, not subinterpreter lifecycle or execution capability. Full interpreter modules and the full workspace/CAPI runtime suite were not run.
Prepared and validated with AI assistance.