Repository navigation
Treat StringCollection as a list collection with the String element type - #28141
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoOct 9, 2026
Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
Dongbo Wang (daxian-dbw) merged 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
7 of 11 tasks
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted binding fix is correct and includes coverage for the regression and preservation behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes scalar PSObject binding to StringCollection parameters by recognizing their string element type.
Changes:
- Classifies
StringCollectionas anIListof strings. - Adds regression tests for scalar, multiple, and untyped-list binding.
| File | Description |
|---|---|
src/System.Management.Automation/engine/CompiledCommandParameter.cs |
Adds StringCollection element-type metadata. |
test/powershell/Language/Parser/ParameterBinding.Tests.ps1 |
Adds parameter-binding regression coverage. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Ilya (iSazonov)
approved these changes
Oct 6, 2026
Justin Chung (jshigetomi)
approved these changes
Oct 9, 2026
Justin Chung (jshigetomi)
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the targeted StringCollection parameter-binding fix and its regression coverage. No merge blockers found.
Dongbo Wang (daxian-dbw)
merged commit Oct 9, 2026
bcd1e69
into
PowerShell:master
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #27969
Treat
StringCollectionas a list collection with theStringelement type.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header