Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

docs: Add deduplication sample for Cloud Scheduler job requests - #14702

Open
camiekim wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
camiekim:master
Open

docs: Add deduplication sample for Cloud Scheduler job requests#14702
camiekim wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
camiekim:master

Conversation

@camiekim

@camiekim camiekim commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/574556578

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style

Post-Approval Actions

  • Please merge this PR for me once it is approved

@camiekim
docs: Add deduplication logic for Cloud Scheduler jobs
4528b45 
This script demonstrates how to deduplicate retried Cloud Scheduler HTTP requests using Firestore, ensuring that duplicate job requests are handled appropriately.

Per b/574556578
@camiekim
docs: Implement tests for job request deduplication
bb0b6b1 
Add unit tests for deduplicating job requests handling.
@camiekim
Rename deduplicate_job.py to deduplicate_job_requests.py
c25ced3
@camiekim
docs: Add google-cloud-firestore to requirements
ebe1326
@camiekim
camiekim requested review from a team as code owners October 30, 2026 13:13
@snippet-bot

snippet-bot Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Oct 30, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Python snippet and corresponding unit tests demonstrating how to deduplicate retried Cloud Scheduler HTTP requests using Firestore. The feedback highlights a contradiction where manual runs (lacking the schedule time header) are rejected with a 400 error despite docstring claims, and suggests allowing them to run directly. Additionally, the reviewer recommends handling expired locks to prevent crashed jobs from blocking retries due to Firestore's asynchronous TTL deletion, along with adding unit tests to cover both scenarios.

Comment thread cloud_scheduler/snippets/deduplicate_job_requests.py Resolved
Comment thread cloud_scheduler/snippets/deduplicate_job_requests.py Resolved
Comment thread cloud_scheduler/snippets/deduplicate_job_requests_test.py Resolved
@camiekim
Rearrange import statements in test file
df6aa3a 
Reordered import statements for consistency.
@camiekim
Update docstring to include documentation link
ee1185a 
Added a link to the Cloud Scheduler documentation for deduplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camiekim