Repository navigation
chore: remove phpMyAdmin from the dev setup - #284
Open
jasdeepkhalsa wants to merge 1 commit into
Open
jasdeepkhalsa wants to merge 1 commit into
jasdeepkhalsa wants to merge 1 commit into
Conversation
It served the MySQL containers only, not Postgres, SQLite or Dolt, and the tests never used it: start.sh started one beside each MySQL database and carried on if it failed. Any database client pointed at the published ports does the same job for every engine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the four phpMyAdmin containers from the Docker dev setup.
start.shstarted one beside each MySQL database and carried on if it failed to start.docker-compose.yml, along with their port settings in.env.exampleandstart.sh. Their start-up, status and image-cleanup steps are gone fromstart.shandstop.sh.DOCKER.mdnow suggests pointing any database client (mysql,psql, DBeaver, TablePlus) at the ports the databases already publish, which works for every engine.No change to DBDiff itself, or to its MySQL, Postgres and SQLite support. CI never started these containers.
🤖 Generated with Claude Code