Repository navigation
fix(cli): 2.x compatibility — shorthand, --nocomments=true, config type/include, --template, SQLite paths - #261
Merged
Conversation
…sing server is a clear error Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s(=true), SQLite paths with dots, clear table-name error, no dynamic-property deprecations Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er evaluated; server check out of DBManager Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182. 2.x's command line, checked option by option against a running 2.0.0, now works in 3.x on MySQL, PostgreSQL and SQLite.
What was broken, in every 3.0 release candidate
dbdiff server1.db1:server2.db2diff--nocomments=true=falsetoo)--nocommentsin native output-- DBDiff migrationheader; the UP/DOWN markers staytype:/include:in.dbdiffor--config--template=…/template:TemplateFormat,{{ $up }}/{{ $down }}as in 2.x)--driver=sqlite server1./var/db/v1.db:…(the README example)v1.dbread as databasev1, tabledbserver1.db1.table1:server2.db2.table3diffwith no settings for a serverHow it was checked
--output,--template,--configand.dbdiffcases produce the same statements.NULLwhere 2.0.0 wrote''; 3.x names the columns inINSERT; a missing--outputdirectory exits 1 where 2.0.0 exited 0 having written nothing.error_reporting=-1.Tests
tests/Unit/LegacyInvocationTest: the shorthand, and--nocomments=….tests/Unit/TwoXCliSqliteTest, with no server needed:--nocomments=truedrops the header and keeps the markers;.dbdiffdecidestypeandinclude, and a flag still wins;--templateshapes the output;LegacyShorthandPostgresTest: the shorthand produces exactlydiff's migration on a live server; differently named tables are refused clearly.DiffCommandTest:buildParamsleavestype/includeunset for the config file, andapplyDefaultssuppliesschema/up.🤖 Generated with Claude Code