Possibly missing Hangul tests for euc-kr #11145

Activity

1. zcorpan

   added

   encoding

   on May 24, 2018
2. r12a commented on May 25, 2018

   

   r12a

   on May 25, 2018

   Contributor

   More actions

   @zcorpan i think https://github.com/w3c/web-platform-tests/blob/master/encoding/legacy-mb-korean/euc-kr/euckr-encode-form.html should contain the hangul character tests(?)
3. zcorpan commented on May 25, 2018

   

   zcorpan

   on May 25, 2018

   MemberAuthor

   More actions

   But that doesn't test error cases if I understand these tests correctly.
4. r12a commented on May 25, 2018

   

   r12a

   on May 25, 2018

   Contributor

   More actions

   (/me trying to remember how those tests worked...) I think the 'error cases' tested for handling of characters that were not included in the legacy encoding, eg. a hangul character in sjis, but euc-kr covers all the hangul characters in Unicode, so there is no need for a hangul-errors test.
5. r12a commented on May 25, 2018

   

   r12a

   on May 25, 2018

   Contributor

   More actions

   fwiw, you may be able to see the pattern more easily by looking a the assertions at https://www.w3.org/International/tests/repo/results/encoding-dbl-byte.en#ko
6. zcorpan commented on May 25, 2018

   

   zcorpan

   on May 25, 2018

   MemberAuthor

   More actions

   If it handles all of hangul, why does adding such a test give 11 code points to be tested?
7. r12a commented on May 25, 2018

   

   r12a

   on May 25, 2018

   Contributor

   More actions

   Not sure. Can you point me to that test file? How did you come up with the characters to check?
8. zcorpan commented on May 25, 2018

   

   zcorpan

   on May 25, 2018

   MemberAuthor

   More actions

   I haven't committed it, but it's the same as https://github.com/w3c/web-platform-tests/pull/11016/files#diff-e6b0b9deee3ae0d27d7b705f1be4ec0a but for euc-kr.