Repository navigation
[css-conditional-3] Remove "unknown" value concept - #6312
Merged
Merged
Conversation
The <general-enclosed> production now just produces "false". See Issue 6175.
Member
Author
|
Plan (from the Blink perspective):
Given that interop is pretty poor currently, I'm optimistic that it will be possible to make this change. |
tabatkins
approved these changes
May 26, 2021
tabatkins
left a comment
Member
There was a problem hiding this comment.
Looks great, and the plan seems spot-on as well. I won't merge since I'm not an editor, but r+
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Jun 3, 2021
The spec has been updated to remove the "unknown" value concept [1]. The <general-enclosed> production now just results in "false". Since support for kUnknown was a work-in-progress that never reached the web surface, we can just remove it. Bug: 1052274 [1] w3c/csswg-drafts#6312 Change-Id: Iec0b54e7d156518a1e5b38d8e88d7d9c8bdb3d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2932039 Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#888553}
Member
Author
|
Investigating a bit more, looks like Chromium already behaves according to the new spec text. The reason Chromium appears to evaluate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production now just produces "false".
See Issue #6175.