You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Replace xxxParams & xxxWithParams with *Options #591
I'm copying my comment as the PR is already merged.
What if instead of withOptions we used withOptional (or withOptionals)? Then we could have optional parameters or configs without causing much confusion.
Not that they are too similar, but most arguments are in the end options in a config. Most are required and rarely when we have optional arguments it might be clearer to label the additional function as WithOptional.
Activity
sgny commentedon Aug 28, 2019
I'm copying my comment as the PR is already merged.
What if instead of
withOptionswe usedwithOptional(orwithOptionals)? Then we could have optional parameters or configs without causing much confusion.MoOx commentedon Aug 30, 2019
You see a problem with
xxxWithOptions&xxxOptionsbecause they look too similar?If so I would go for
xxxWithOptions&xxxMakeOptionssgny commentedon Aug 31, 2019
Not that they are too similar, but most arguments are in the end options in a config. Most are required and rarely when we have optional arguments it might be clearer to label the additional function as
WithOptional.