Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

Add possibility to not register shutdown hook in NioClient #358

Closed
#359
Closed
Add possibility to not register shutdown hook in NioClient#358
#359
Labels
enhancement
Milestone
v3.6.3

Description

@SvenssonWeb
SvenssonWeb
opened on Dec 6, 2024

dnsjava/src/main/java/org/xbill/DNS/NioClient.java

Line 63 in d445fe8

Runtime.getRuntime().addShutdownHook(closeThread);

I'm currently facing an issue where I have queued requests to be sent via this library when the Java process receives a shutdown signal (SIGTERM).
When trying to complete the queued requests the DNS Client has already terminated it's internals because of the registered ShutdownHook.

Could we add flag or setting to not register a ShutdownHook and instead place the burden on the consumer of DNSJava to clean up correctly?

Activity

  1. ibauersachs commented on Dec 6, 2024

    @ibauersachs
    ibauersachs
    on Dec 6, 2024
    Member

    Yes, this can be added. Would you mind creating a PR?

  2. ibauersachs
    added
    enhancement
    on Dec 6, 2024

  3. SvenssonWeb commented on Dec 6, 2024

    @SvenssonWeb
    SvenssonWeb
    on Dec 6, 2024
    ContributorAuthor

    I can try modeling it after existing system properties flags in the code base.

  4. SvenssonWeb
    added 2 commits that reference this issue on Dec 6, 2024

    Optionally disable ShutdownHook in NioClient

    8c7335c

    Optionally disable ShutdownHook in NioClient

    7131315
  5. ibauersachs
    linked a pull request that will close this issueOptionally disable ShutdownHook in NioClient #359on Dec 6, 2024
  6. ibauersachs
    closed this as completedin #359on Dec 6, 2024
  7. ibauersachs
    added this to the v3.6.3 milestone on Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions